From: "Martin K. Petersen" Subject: Re: [PATCH v3 2/5] lib: introduce crc_t10dif_update() Date: Tue, 28 Apr 2015 19:07:30 -0400 Message-ID: References: <1429972410-7146-1-git-send-email-akinobu.mita@gmail.com> <1429972410-7146-3-git-send-email-akinobu.mita@gmail.com> <1430242716.660.70.camel@schen9-desk2.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Akinobu Mita , target-devel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, Nicholas Bellinger , Sagi Grimberg , "Martin K. Petersen" , Christoph Hellwig , "James E.J. Bottomley" To: Tim Chen Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:43271 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031262AbbD1XHr (ORCPT ); Tue, 28 Apr 2015 19:07:47 -0400 In-Reply-To: <1430242716.660.70.camel@schen9-desk2.jf.intel.com> (Tim Chen's message of "Tue, 28 Apr 2015 10:38:36 -0700") Sender: linux-crypto-owner@vger.kernel.org List-ID: >>>>> "Tim" == Tim Chen writes: Tim> There are a lot of duplicated code between crc_t10dif_update and Tim> crc_t10dif. The only difference is for the update function we Tim> import the crc value. I will prefer that we consolidate the code Tim> into a local inline function that crc_t10dif_update and crc_t10dif Tim> invoke to get rid of all the duplication. I'm OK with that approach. -- Martin K. Petersen Oracle Linux Engineering