From: Thomas Petazzoni Subject: Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode Date: Tue, 12 May 2015 17:49:36 +0200 Message-ID: <20150512174936.284783d4@free-electrons.com> References: <1431445063-20226-1-git-send-email-maxime.ripard@free-electrons.com> <1431445063-20226-3-git-send-email-maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Vinod Koul , Dan Williams , Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Lior Amsalem , Thomas Petazzoni , Herbert Xu , "David S. Miller" To: Maxime Ripard Return-path: Received: from down.free-electrons.com ([37.187.137.238]:57900 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753185AbbELPtl (ORCPT ); Tue, 12 May 2015 11:49:41 -0400 In-Reply-To: <1431445063-20226-3-git-send-email-maxime.ripard@free-electrons.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Maxime, On Tue, 12 May 2015 17:37:37 +0200, Maxime Ripard wrote: > Required properties: > -- compatible: Should be "marvell,orion-xor" > +- compatible: Should be "marvell,orion-xor" or "marvell,a38x-xor" I believe the new compatible string should be armada-380-xor or armada380-xor. Wildcards in compatible strings are generally not recommended, and we don't use the a38x- prefix anywhere in the tree, as far as I can see: drivers/ata/ahci_mvebu.c: { .compatible = "marvell,armada-380-ahci", }, drivers/bus/mvebu-mbus.c: { .compatible = "marvell,armada380-mbus", drivers/mmc/host/sdhci-pxav3.c: .compatible = "marvell,armada-380-sdhci", drivers/rtc/rtc-armada38x.c: { .compatible = "marvell,armada-380-rtc", }, drivers/thermal/armada_thermal.c: .compatible = "marvell,armada380-thermal", drivers/usb/host/xhci-plat.c: { .compatible = "marvell,armada-380-xhci"}, drivers/watchdog/orion_wdt.c: .compatible = "marvell,armada-380-wdt", Yes, we're not very consistent between armada380 and armada-380, but we're not using a38x anywhere. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com