From: Thomas Petazzoni Subject: Re: [PATCH 5/8] dmaengine: mv_xor: bug fix for racing condition in descriptors cleanup Date: Tue, 12 May 2015 17:51:17 +0200 Message-ID: <20150512175117.1eaff739@free-electrons.com> References: <1431445063-20226-1-git-send-email-maxime.ripard@free-electrons.com> <1431445063-20226-6-git-send-email-maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Cc: Vinod Koul , Dan Williams , Gregory Clement , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Lior Amsalem , Thomas Petazzoni , Herbert Xu , "David S. Miller" To: Maxime Ripard Return-path: Received: from down.free-electrons.com ([37.187.137.238]:58036 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932843AbbELPv1 convert rfc822-to-8bit (ORCPT ); Tue, 12 May 2015 11:51:27 -0400 In-Reply-To: <1431445063-20226-6-git-send-email-maxime.ripard@free-electrons.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Maxime, On Tue, 12 May 2015 17:37:40 +0200, Maxime Ripard wrote: > From: Lior Amsalem > > This patch fixes a bug in the XOR driver where the cleanup function can be > called and free descriptors that never been processed by the engine (which > result in data errors). > > The cleanup function will free descriptors based on the ownership bit in > the descriptors. > > Signed-off-by: Lior Amsalem > Reviewed-by: Ofer Heifetz > Signed-off-by: Maxime Ripard If this is fixing a bug, shouldn't it be Cc'ed to stable@ ? But then it needs to be the first patch in the series. >From what I remember, this series both fixes some issues *and* adds RAID6 support. We need to separate out the two things so that the fixes can be propagated to stable. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com