From: Thomas Petazzoni Subject: Re: [PATCH 2/8] dmaengine: mv_xor: add support for a38x command in descriptor mode Date: Tue, 12 May 2015 18:05:39 +0200 Message-ID: <20150512180539.4ea5d158@free-electrons.com> References: <1431445063-20226-1-git-send-email-maxime.ripard@free-electrons.com> <1431445063-20226-3-git-send-email-maxime.ripard@free-electrons.com> <20150512174936.284783d4@free-electrons.com> <20150512155824.GJ19927@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Maxime Ripard , Vinod Koul , Dan Williams , Gregory Clement , Jason Cooper , Sebastian Hesselbarth , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Lior Amsalem , Thomas Petazzoni , Herbert Xu , "David S. Miller" To: Andrew Lunn Return-path: In-Reply-To: <20150512155824.GJ19927@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org Andrew, On Tue, 12 May 2015 17:58:24 +0200, Andrew Lunn wrote: > A quick grep for marvell,orion, marvell,kirkwood and marvell,dove > suggests it should have the - if we want to be consistent with older > Marvell devices. As you said, starting with marvell,armanda it gets > pretty inconsistent :-( Yes, with the "-" would be better IMO. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com