From: "Suthikulpanit, Suravee" Subject: Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency Date: Sat, 16 May 2015 15:14:36 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: Rafael Wysocki , Len Brown , "Catalin Marinas" , Will Deacon , "Lendacky, Thomas" , "herbert@gondor.apana.org.au" , David Miller , "Arnd Bergmann" , Mark Salter , Hanjun Guo , Al Stone , Grant Likely , "Duran, Leo" , linux-arm , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , netdev , "linux-crypto@vger.kernel.org" , Rob Herring , Murali Karicheri To: Bjorn Helgaas Return-path: Received: from mail-by2on0128.outbound.protection.outlook.com ([207.46.100.128]:36345 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752127AbbEPPOl convert rfc822-to-8bit (ORCPT ); Sat, 16 May 2015 11:14:41 -0400 In-Reply-To: Content-Language: en-US Content-ID: Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Bjorn, On 5/16/15, 07:41, "Bjorn Helgaas" wrote: >On Fri, May 15, 2015 at 4:23 PM, Suravee Suthikulpanit > wrote: >> This patch refactors of_pci_dma_configure() into a more generic >> pci_dma_configure(), which can be reused by non-OF code. >> Then, it adds support for setting up PCI device DMA coherency from >> ACPI _CCA object that should normally be specified in the DSDT node >> of its PCI host bridge.. > >From the changelog, it sounds like you might be able to split this >into two patches: > >1) Refactor of_pci_dma_configure(), with no functional change >2) Add support for using _CCA > >If that's possible, please do so to make this easier to review. > >Bjorn Yes, I can separate the patch out. This would mainly affect ACPI+PCI support for ARM64 (which is in progress). Thanks, Surafvee