From: Boris Brezillon Subject: Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA Date: Mon, 25 May 2015 13:08:12 +0200 Message-ID: <20150525130812.375cfebc@bbrezillon> References: <1432301642-11470-1-git-send-email-boris.brezillon@free-electrons.com> <1432301642-11470-3-git-send-email-boris.brezillon@free-electrons.com> <20150525075812.GA28689@gondor.apana.org.au> <20150525101016.252a1dc0@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Herbert Xu" , "David S. Miller" , linux-crypto@vger.kernel.org, "Arnaud Ebalard" , "Thomas Petazzoni" , "Gregory CLEMENT" , "Jason Cooper" , "Sebastian Hesselbarth" , "Andrew Lunn" , "Tawfik Bayouk" , "Lior Amsalem" , "Nadav Haklai" , "Eran Ben-Avi" , "Rob Herring" , "Pawel Moll" , "Mark Rutland" , "Ian Campbell" , "Kumar Gala" , devicetree@vger.kernel.org To: "Imre Kaloz" Return-path: Received: from down.free-electrons.com ([37.187.137.238]:57593 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751096AbbEYLIQ (ORCPT ); Mon, 25 May 2015 07:08:16 -0400 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Imre, On Mon, 25 May 2015 12:44:44 +0200 "Imre Kaloz" wrote: > Hi Boris, > > On Mon, 25 May 2015 10:10:16 +0200, Boris Brezillon > wrote: > > > > > Yep, I noticed that after submitting this version. I guess I only > > needed the import function for my test cases and thus forgot to > > implement the import function. > > Anyway, I just added the the import functions (they'll be available in > > my v4). > > Given the driver is supposed to work on platforms up to 38x, could v4 > include the missing bindings for those platforms, too? Sure, what's missing ? I already added the cesazX clocks and the "marvell,armada-38x-crypto" compatible string ? Best Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com