From: Ulf Hansson Subject: Re: [PATCH 04/13] mmc: omap_hsmmc: No need to check DMA channel validity at module remove Date: Thu, 28 May 2015 09:20:18 +0200 Message-ID: References: <1432646768-12532-1-git-send-email-peter.ujfalusi@ti.com> <1432646768-12532-5-git-send-email-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Vinod Koul , Tony Lindgren , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dan Williams , dmaengine@vger.kernel.org, linux-serial@vger.kernel.org, linux-omap , linux-mmc , linux-crypto@vger.kernel.org, "linux-spi@vger.kernel.org" , linux-media@vger.kernel.org, alsa-devel@alsa-project.org To: Peter Ujfalusi Return-path: In-Reply-To: <1432646768-12532-5-git-send-email-peter.ujfalusi@ti.com> Sender: linux-media-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On 26 May 2015 at 15:25, Peter Ujfalusi wrote: > The driver will not probe without valid DMA channels so no need to check > if they are valid when the module is removed. > > Signed-off-by: Peter Ujfalusi > CC: Ulf Hansson Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/mmc/host/omap_hsmmc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 2cd828f42151..57bb85930f81 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -2190,10 +2190,8 @@ static int omap_hsmmc_remove(struct platform_device *pdev) > if (host->use_reg) > omap_hsmmc_reg_put(host); > > - if (host->tx_chan) > - dma_release_channel(host->tx_chan); > - if (host->rx_chan) > - dma_release_channel(host->rx_chan); > + dma_release_channel(host->tx_chan); > + dma_release_channel(host->rx_chan); > > pm_runtime_put_sync(host->dev); > pm_runtime_disable(host->dev); > -- > 2.3.5 >