From: Boris Brezillon Subject: Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Date: Mon, 22 Jun 2015 09:23:36 +0200 Message-ID: <20150622092336.5949e258@bbrezillon> References: <1434635190-27733-1-git-send-email-boris.brezillon@free-electrons.com> <20150619142444.GA15234@gondor.apana.org.au> <20150621102418.2ea74910@bbrezillon> <20150621082717.GA29128@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Cc: Paul Gortmaker , "David S. Miller" , linux-crypto@vger.kernel.org, Arnaud Ebalard , Tawfik Bayouk , Lior Amsalem , Nadav Haklai , Eran Ben-Avi , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , LKML , Jason Gunthorpe Return-path: Received: from down.free-electrons.com ([37.187.137.238]:55776 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756122AbbFVHXl convert rfc822-to-8bit (ORCPT ); Mon, 22 Jun 2015 03:23:41 -0400 In-Reply-To: <20150621082717.GA29128@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Herbert, On Sun, 21 Jun 2015 16:27:17 +0800 Herbert Xu wrote: > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote: > > > > Indeed. Here is a patch fixing that. > > I think you should just kill COMPILE_TEST instead of adding ARM. The following patch is killing the COMPILE_TEST dependency. -- >8 -- >From 772232fe4f5e597e45701dd9c3ab68c4a065342f Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Mon, 22 Jun 2015 09:22:14 +0200 Subject: [PATCH] crypto: marvell/CESA: remove COMPILE_TEST dependency The CESA driver calls phys_to_virt() which is not available on all architectures. Remove the depency on COMPILE_TEST to prevent building this driver on non ARM architectures. Signed-off-by: Boris Brezillon Reported-by: Paul Gortmaker Suggested-by: Herbert Xu --- drivers/crypto/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index cdca762..f965d0c 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -176,7 +176,7 @@ config CRYPTO_DEV_MV_CESA config CRYPTO_DEV_MARVELL_CESA tristate "New Marvell's Cryptographic Engine driver" - depends on (PLAT_ORION || ARCH_MVEBU || COMPILE_TEST) && HAS_DMA && HAS_IOMEM + depends on PLAT_ORION || ARCH_MVEBU select CRYPTO_AES select CRYPTO_DES select CRYPTO_BLKCIPHER -- 1.9.1