From: Paul Gortmaker Subject: Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA Date: Wed, 24 Jun 2015 20:00:38 -0400 Message-ID: <20150625000037.GK31584@windriver.com> References: <1434635190-27733-1-git-send-email-boris.brezillon@free-electrons.com> <20150619142444.GA15234@gondor.apana.org.au> <20150621102418.2ea74910@bbrezillon> <20150621082717.GA29128@gondor.apana.org.au> <20150622092336.5949e258@bbrezillon> <20150622075910.GA7659@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Lior Amsalem , Andrew Lunn , Nadav Haklai , Mark Rutland , Boris Brezillon , Russell King - ARM Linux , Tawfik Bayouk , Eran Ben-Avi , Jason Gunthorpe , "linux-next@vger.kernel.org" , Sebastian Hesselbarth , devicetree@vger.kernel.org, Jason Cooper , Pawel Moll , Ian Campbell , Arnaud Ebalard , Rob Herring , Gregory CLEMENT , "linux-arm-kernel@lists.infradead.org" , Thomas Petazzoni , To: Herbert Xu Return-path: Content-Disposition: inline In-Reply-To: <20150622075910.GA7659@gondor.apana.org.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-crypto.vger.kernel.org [Re: [PATCH v7 00/14] crypto: add a new driver for Marvell's CESA] On 22/06/2015 (Mon 15:59) Herbert Xu wrote: > On Mon, Jun 22, 2015 at 09:23:36AM +0200, Boris Brezillon wrote: > > Hi Herbert, > > > > On Sun, 21 Jun 2015 16:27:17 +0800 > > Herbert Xu wrote: > > > > > On Sun, Jun 21, 2015 at 10:24:18AM +0200, Boris Brezillon wrote: > > > > > > > > Indeed. Here is a patch fixing that. > > > > > > I think you should just kill COMPILE_TEST instead of adding ARM. > > > > The following patch is killing the COMPILE_TEST dependency. > > Patch applied. Just a heads up, this driver is still killing a couple of linux-next builds today and for the past few days. drivers/crypto/mv_cesa.c:1037:2: error: implicit declaration of function 'of_get_named_gen_pool' [-Werror=implicit-function-declaration] http://kisskb.ellerman.id.au/kisskb/buildresult/12448851/ http://kisskb.ellerman.id.au/kisskb/buildresult/12448776/ Missing dependency on CONFIG_OF_ presumably. Paul. -- > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt