From: Herbert Xu Subject: Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE Date: Mon, 6 Jul 2015 15:38:33 +0800 Message-ID: <20150706073833.GB20192@gondor.apana.org.au> References: <1435814320-30347-1-git-send-email-lokeshvutla@ti.com> <1435814320-30347-2-git-send-email-lokeshvutla@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, davem@davemloft.net, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, t-kristo@ti.com, nsekhar@ti.com To: Lokesh Vutla Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:41940 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753555AbbGFHig (ORCPT ); Mon, 6 Jul 2015 03:38:36 -0400 Content-Disposition: inline In-Reply-To: <1435814320-30347-2-git-send-email-lokeshvutla@ti.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Jul 02, 2015 at 10:48:31AM +0530, Lokesh Vutla wrote: > OMAP AES driver returns an error if the data is not aligned with > AES_BLOCK_SIZE bytes. > But OMAP AES hw allows data input upto 1 byte aligned, but still > zeros are to be appended and complete AES_BLOCK_SIZE has to be written. > And correct length has to be passed in LENGTH field. > Adding support for inputs not aligned with AES_BLOCK_SIZE. > > Signed-off-by: Lokesh Vutla Please explain the purpose of this patch. As it stands your change log makes no sense. If you're relaxing the check for GCM support then you should state that explicitly. Because partial blocks make no sense otherwise. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt