From: Herbert Xu Subject: Re: [PATCH v2 1/8] crypto: support (de)compression API that doesn't require tfm object Date: Thu, 20 Aug 2015 15:50:35 +0800 Message-ID: <20150820075035.GA27535@gondor.apana.org.au> References: <1440052504-15442-1-git-send-email-iamjoonsoo.kim@lge.com> <1440052504-15442-2-git-send-email-iamjoonsoo.kim@lge.com> <20150820064728.GA26840@gondor.apana.org.au> <20150820075217.GA30260@js1304-P5Q-DELUXE> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Minchan Kim , Nitin Gupta , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, "David S. Miller" , Stephan Mueller To: Joonsoo Kim Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:43914 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbbHTHut (ORCPT ); Thu, 20 Aug 2015 03:50:49 -0400 Content-Disposition: inline In-Reply-To: <20150820075217.GA30260@js1304-P5Q-DELUXE> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Aug 20, 2015 at 04:52:17PM +0900, Joonsoo Kim wrote: > > Hmm... I guess there is no problem. crypto_alg object fetched by > crypto_get_comp() introduced in this patch could be hardware device > algorithm which is same one that we can eventually fetch from tfm object. > So, this approach would correctly track the crypto_alg regardless > it is a hardware one or not. If there is some dependency between > algorithm and tfm, it can't support _noctx API. Am I missing > something? Your approach limits what hardware devices we can support in future. It is fairly common for hardware drivers to only allocate resources when a tfm is created. With your tfmless interface, the driver would have to unconditionally allocate resources. It is essentially a global tfm without the tfm. > Yes, I thought this way before, but, current way is much simpler so > I try it first. If it is not acceptable, I will implement this > approach. Please go with a global tfm. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt