From: Herbert Xu Subject: Re: [PATCH v2] crypto/caam: add backlogging support Date: Fri, 18 Sep 2015 22:10:40 +0800 Message-ID: <20150918141040.GL9249@gondor.apana.org.au> References: <1442434361-15123-1-git-send-email-alexandru.porosanu@freescale.com> <20150918132443.GG7638@gondor.apana.org.au> <20150918135017.GA9152@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "linux-crypto@vger.kernel.org" , Geanta Neag Horia , Pop Mircea To: Porosanu Alexandru Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:43759 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752810AbbIROKn (ORCPT ); Fri, 18 Sep 2015 10:10:43 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Sep 18, 2015 at 02:07:38PM +0000, Porosanu Alexandru wrote: > > MAY_BACKLOG requests will fail once you run out of memory (f.i. backlogging using crypto_queue) > Now, for this patch requests will be dropped if there are no more "backlogging" slots available. > Would limiting the # of tfms w/MAY_BACKLOG associated with the driver to the # of backlogging slots be OK? Sure running out of memory is obviously a good reason to fail a request. But if you still have memory MAY_BACKLOG must not fail. Each tfm must be able to submit at least one MAY_BACKLOG request, that's the whole point of this flag. It's used for disk encryption where failing is not an option. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt