From: Russell King - ARM Linux Subject: [PATCH 0/6] Sparse related fixes Date: Sun, 18 Oct 2015 18:30:39 +0100 Message-ID: <20151018173039.GA9737@n2100.arm.linux.org.uk> References: <20151009102904.GL32532@n2100.arm.linux.org.uk> <20151009104637.GA18798@n2100.arm.linux.org.uk> <20151009194309.GA7401@n2100.arm.linux.org.uk> <20151018161649.GA6651@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Herbert Xu , Jason Cooper , linux-crypto@vger.kernel.org, Thomas Petazzoni To: Boris Brezillon , Arnaud Ebalard Return-path: Received: from pandora.arm.linux.org.uk ([78.32.30.218]:45447 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbbJRRaw (ORCPT ); Sun, 18 Oct 2015 13:30:52 -0400 Content-Disposition: inline In-Reply-To: <20151018161649.GA6651@n2100.arm.linux.org.uk> Sender: linux-crypto-owner@vger.kernel.org List-ID: Continuing on from the previous set of 18 patches, I also fixed a number of sparse problems and other cleanups. I don't deem these suitable for -rc merging, especially now that we're basically at -rc6. The first patch switches the driver over to appropriately using the relaxed IO accessors - this avoids calling out to the heavy barrier on every read and write operation, but only calling out on those which really matter. We switch to using dma_addr_t for DMA addresses which are not accessed by hardware, and using gfp_t for the get_free_page flags. String-based MMIO accesses are used instead of plain memcpy()/memset() which prevents us potentially stumbling over GCC optimisations that it thinks it may make with these functions. We convert as much of the hardware state to __le32 endian markings, and use cpu_to_le32() as appropriate. A number of places are left unfixed, as we temporarily store CPU native endian values at these locations; these warnings should not be fixed (basically, only appropriate sparse warnings should be fixed without penalising code.) drivers/crypto/marvell/cesa.h | 44 ++++++++++++++++++++--------------------- drivers/crypto/marvell/cipher.c | 13 ++++++------ drivers/crypto/marvell/hash.c | 23 +++++++++++---------- drivers/crypto/marvell/tdma.c | 42 ++++++++++++++++++++------------------- 4 files changed, 62 insertions(+), 60 deletions(-) -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.