From: Rob Herring Subject: Re: [RESEND PATCH 4/4] crypto: rk_crypto - add DT bindings documentation Date: Mon, 2 Nov 2015 09:39:51 -0600 Message-ID: References: <1446193369-4453-1-git-send-email-zain.wang@rock-chips.com> <1446193369-4453-5-git-send-email-zain.wang@rock-chips.com> <20151030140334.GB31073@leverpostej> <56372942.2080900@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Mark Rutland , zhengsq@rock-chips.com, hl@rock-chips.com, Herbert Xu , David Miller , Michael Turquette , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Pawel Moll , Ian Campbell , Kumar Gala , Russell King - ARM Linux , "linux-kernel@vger.kernel.org" , linux-crypto@vger.kernel.org, "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , eddie.cai@rock-chips.com To: Zain Return-path: In-Reply-To: <56372942.2080900@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Nov 2, 2015 at 3:13 AM, Zain wrote: > Hi Mark > > On 2015=E5=B9=B410=E6=9C=8830=E6=97=A5 22:03, Mark Rutland wrote: >> On Fri, Oct 30, 2015 at 04:22:49PM +0800, Zain Wang wrote: >>> Add DT bindings documentation for the rk3288 crypto drivers. >>> >>> Signed-off-by: Zain Wang >>> --- >>> +Required properties: >>> +- compatible: should be "rockchip,crypto" >> Choose a more specific name. Rockchip could easily come up with anot= her >> crypto accelerator later. > ok! done. > rk3288_crypto may be better than crypto. Yes, but use '-' not '_'. Rob