From: Herbert Xu Subject: Re: [PATCH] crypto: sun4i-ss: add missing statesize Date: Fri, 6 Nov 2015 12:56:39 +0800 Message-ID: <20151106045639.GA14722@gondor.apana.org.au> References: <1446709737-11316-1-git-send-email-clabbe.montjoie@gmail.com> <20151105160719.GG6114@lukather> Reply-To: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: LABBE Corentin , davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Ripard Return-path: Content-Disposition: inline In-Reply-To: <20151105160719.GG6114@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-crypto.vger.kernel.org On Thu, Nov 05, 2015 at 08:07:19AM -0800, Maxime Ripard wrote: > > On Thu, Nov 05, 2015 at 08:48:57AM +0100, LABBE Corentin wrote: > > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > > A recent change make impossible to load them without giving statesize. > > Which one? We recently disabled ahash drivers that do not declare statesize because it can lead to a crash when the driver is used through algif. Not declaring statesize is a bug anyway but the fact that it is exported through algif makes it much worse. > > This patch specifiy statesize for sha1 and md5. > > > > Signed-off-by: LABBE Corentin > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Please also add a Fixes tag (and the stable version it applies to). I don't see the point for a fixes tag as it would simply refer to the original patch-set that added the driver. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt