From: Andy Shevchenko Subject: Re: [PATCH 02/13] dmaengine: Introduce dma_request_slave_channel_compat_reason() Date: Wed, 18 Nov 2015 18:00:41 +0200 Message-ID: References: <1432646768-12532-1-git-send-email-peter.ujfalusi@ti.com> <6358656.jIv3GGCCXu@wuerfel> <8215351.e99Q2vhQ5T@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Peter Ujfalusi , Vinod Koul , Geert Uytterhoeven , Tony Lindgren , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dan Williams , dmaengine , "linux-serial@vger.kernel.org" , "linux-omap@vger.kernel.org" , Linux MMC List , linux-crypto , linux-spi , Linux Media Mailing List , ALSA Development Mailing List To: Arnd Bergmann Return-path: Received: from mail-yk0-f195.google.com ([209.85.160.195]:33958 "EHLO mail-yk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755191AbbKRQAn convert rfc822-to-8bit (ORCPT ); Wed, 18 Nov 2015 11:00:43 -0500 In-Reply-To: <8215351.e99Q2vhQ5T@wuerfel> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Nov 18, 2015 at 5:51 PM, Arnd Bergmann wrote: > On Wednesday 18 November 2015 17:43:04 Andy Shevchenko wrote: >> > >> > I assume that the sst-firmware.c case is a mistake, it should just= use a >> > plain DMA_SLAVE and not DMA_MEMCPY. >> >> Other way around. >> > > Ok, I see. In that case I guess it also shouldn't call > dmaengine_slave_config(), right? I don't think that's valid > on a MEMCPY channel. Hmm=E2=80=A6 That's right, though I suspect still one thing why it's do= ne this way. Let's ask Vinod and Liam about that. --=20 With Best Regards, Andy Shevchenko