From: Herbert Xu Subject: Re: [RFC PATCH 1/2] Crypto support aesni rfc5288 Date: Tue, 24 Nov 2015 18:30:33 +0800 Message-ID: <20151124103033.GA623@gondor.apana.org.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Tom Herbert , netdev@vger.kernel.org, davem@davemloft.net, Sowmini Varadhan , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Nov 23, 2015 at 09:42:44AM -0800, Dave Watson wrote: > Support rfc5288 using intel aesni routines. See also rfc5246. > > AAD length is 13 bytes padded out to 16. Padding bytes have to be > passed in in scatterlist currently, which probably isn't quite the > right fix. > > The assoclen checks were moved to the individual rfc stubs, and the > common routines support all assoc lengths. I know this is just an RFC. But if we were going to add an rfc5288 template then you should add a C version first, then followed by the aesni optimised version. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt