From: Herbert Xu Subject: Re: [PATCH v2 0/3] dmaengine: Add supports for APM X-Gene SoC CRC32C accerlerator driver Date: Mon, 30 Nov 2015 16:39:50 +0800 Message-ID: <20151130083950.GA7792@gondor.apana.org.au> References: <1447665169-14003-1-git-send-email-rsahu@apm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, Vinod Koul , dan.j.williams@intel.com, dmaengine@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com, linux-crypto@vger.kernel.org, Kaustubh Gondkar To: Rameshwar Sahu Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:57336 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753314AbbK3IkX (ORCPT ); Mon, 30 Nov 2015 03:40:23 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Nov 30, 2015 at 02:06:03PM +0530, Rameshwar Sahu wrote: > On Mon, Nov 16, 2015 at 2:42 PM, wrote: > > From: Rameshwar Prasad Sahu > > > > This patch implements support for APM X-Gene SoC CRC32C h/w accelerator driver > > and adds CRC32C computations support in dmaengine framework. APM X-Gene SoC has > > DMA engine capable of performing CRC32C computations. > > > > v2 changes: > > 1. Added helper function in dmaengine framework > > 2. Documented CRC32C support in Documentations/dmaengine/provider.txt > > 3. Fixed algo name > > 4. Fixed coding style issues > > > > Signed-off-by: Rameshwar Prasad Sahu > > --- > > > > Rameshwar Prasad Sahu (3): > > dmaengine: Add support for new feature CRC32C computations > > dmaengine: xgene-dma: Add support for CRC32C computations via DMA > > engine > > Crypto: Add support for APM X-Gene SoC CRC32C h/w accelerator driver > > > > Documentation/dmaengine/provider.txt | 3 + > > drivers/crypto/Kconfig | 8 + > > drivers/crypto/Makefile | 1 + > > drivers/crypto/xgene-crc32c.c | 234 +++++++++++++++++++++++++ > > drivers/dma/dmaengine.c | 2 + > > drivers/dma/xgene-dma.c | 314 ++++++++++++++++++++++++++++++++-- > > include/linux/dmaengine.h | 13 ++ > > 7 files changed, 560 insertions(+), 15 deletions(-) > > create mode 100755 drivers/crypto/xgene-crc32c.c > > Any Comments on above patchset ?? The main user of crc32c is lib/libcrc32c.c. Unfortunately it is entire synchronous so it won't be able to use your crc32c driver at all. So who is going to be using this? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt