From: Tadeusz Struk Subject: Re: crypto: qat - update init_esram for C3xxx dev type Date: Fri, 15 Jan 2016 10:29:12 -0800 Message-ID: <56993A78.4030500@intel.com> References: <1452277194-4804-1-git-send-email-tadeusz.struk@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: pingchao.yang@intel.com, linux-crypto@vger.kernel.org To: herbert@gondor.apana.org.au Return-path: Received: from mga11.intel.com ([192.55.52.93]:29667 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754427AbcAOSc4 (ORCPT ); Fri, 15 Jan 2016 13:32:56 -0500 In-Reply-To: <1452277194-4804-1-git-send-email-tadeusz.struk@intel.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 01/08/2016 10:19 AM, Tadeusz Struk wrote: > There is no esram on C3xxx devices so we don't need to wait for > it to initialize. > > Signed-off-by: Tadeusz Struk > > --- > drivers/crypto/qat/qat_common/qat_hal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/crypto/qat/qat_common/qat_hal.c b/drivers/crypto/qat/qat_common/qat_hal.c > index 7786e6e..daecd71 100644 > --- a/drivers/crypto/qat/qat_common/qat_hal.c > +++ b/drivers/crypto/qat/qat_common/qat_hal.c > @@ -456,6 +456,9 @@ static int qat_hal_init_esram(struct icp_qat_fw_loader_handle *handle) > unsigned int csr_val; > int times = 30; > > + if (handle->pci_dev->device == ADF_C3XXX_PCI_DEVICE_ID) > + return 0; > + > csr_val = ADF_CSR_RD(csr_addr, 0); > if ((csr_val & ESRAM_AUTO_TINIT) && (csr_val & ESRAM_AUTO_TINIT_DONE)) > return 0; > Herbert, This fixes another BAR related issue on C3XXX device, which prevents C3XXX device from being initialized. Please include this fix into 4.5. The patch is created on top of the "[V3] crypto: qat - fix timeout issues" Thanks, -- TS