From: Corentin LABBE Subject: Re: [RESEND PATCH 0/2] crypto: sunxi-ss: fix 64-bit compilation Date: Sat, 16 Jan 2016 21:32:45 +0100 Message-ID: <569AA8ED.7050404@gmail.com> References: <1452252249-12040-1-git-send-email-andre.przywara@arm.com> Reply-To: clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Herbert Xu , "David S . Miller" , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andre Przywara , Maxime Ripard , Chen-Yu Tsai , Arnd Bergmann Return-path: In-Reply-To: <1452252249-12040-1-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-crypto.vger.kernel.org Le 08/01/2016 12:24, Andre Przywara a =C3=A9crit : > (resending to add linux-crypto, patches unchanged) >=20 > Hi, >=20 > these two patches provide a different approach to an issue I tried > to fix lately [1]. > Instead of casting everything I now promote local types to size_t, so > that the min3() arguments naturally match in type. > As size_t is defined as "unsigned int" on 32-bit architectures > anyway, that actually does not change anything there, but instead > provides a clean approach to get it compiled for arm64. >=20 > I split this up because 1/2 seems much cleaner to me than 2/2, so we > can have a separate discussion/merge process on this. >=20 > Cheers, > Andre. >=20 > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/3= 95689.html >=20 > Andre Przywara (2): > crypto: sunxi-ss-cipher: promote variables to match types in min3() > calls > crypto: sunxi-ss-hash: promote variables to match types in min3() > calls >=20 > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 20 ++++++++++---------- > drivers/crypto/sunxi-ss/sun4i-ss-hash.c | 12 ++++++------ > drivers/crypto/sunxi-ss/sun4i-ss.h | 2 +- > 3 files changed, 17 insertions(+), 17 deletions(-) >=20 Hello Sorry for this late answer. I am in trouble with those patch, so we have with Andre a long conversation= about it. Basically, sun4i-ss will never be available on 64bits platform. (A64 will h= ave a totally new crypto engine). So letting it to compile under 64bit arch is only useful when goal is to ad= d COMPILE_TEST for it. But COMPILE_TEST cannot simply be added with those patch since some arches = (x86/x86_64 at least) does not have writesl/readsl available. The conclusion is that it is simpler to block 64bit build for sun4i-ss. Regards LABBE Corentin --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.