From: Raj Ammanur Subject: Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering Date: Wed, 20 Jan 2016 09:30:18 -0800 Message-ID: References: <20160119074343.GA7753@gondor.apana.org.au> <20160120032537.GA18992@gondor.apana.org.au> <20160120083806.GA20214@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: linux-crypto@vger.kernel.org To: Herbert Xu Return-path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:38527 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934015AbcATRaU (ORCPT ); Wed, 20 Jan 2016 12:30:20 -0500 Received: by mail-wm0-f54.google.com with SMTP id b14so41141026wmb.1 for ; Wed, 20 Jan 2016 09:30:19 -0800 (PST) In-Reply-To: <20160120083806.GA20214@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Jan 20, 2016 at 12:38 AM, Herbert Xu wrote: > On Wed, Jan 20, 2016 at 12:31:46AM -0800, Raj Ammanur wrote: >> >> RAJ: ok. would it also be useful to be able to set the length as a module >> load time parameter? > > That would be a bad interface. If we wanted to have an adjustable > limit it needs to be set by the entity that is creating the tfm, > i.e., IPsec. > RAJ: Agreed, but it also has been useful for me for testing/debugging to be able to specify the size to a KLM, since the other stuff is built into the kernel. We atleast got rid of the dup acks, although the out of order pkts still remain. >> RAJ: hmm, thats true, yes. >> >> so, is the below description, that you wrote in one of your email replies, >> the solution for which you are going to create a patch? >> >> > So what I'm thinking of is to have the softirq path forcibly regain >> > control from cryptd where possible. This is tricky because cryptd >> > might be in the middle of processing a request. So that's why I'd >> > like to disable softirqs while we're processing a request. > > Yes. > RAJ: Will wait for the patch to take a look and try it out and test it. Sincerely appreciate it. thanks --Raj > Cheers, > -- > Email: Herbert Xu > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html