From: Tim Chen Subject: Re: [PATCH] crypto : sha1-mb : Add missing args_digest offset Date: Mon, 25 Jan 2016 17:17:57 -0800 Message-ID: <1453771077.21738.15.camel@schen9-desk2.jf.intel.com> References: <1453769169-27479-1-git-send-email-megha.dey@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux=kernel@vger.kernel.org, Megha Dey To: Megha Dey Return-path: Received: from mga03.intel.com ([134.134.136.65]:4321 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933143AbcAZBR6 (ORCPT ); Mon, 25 Jan 2016 20:17:58 -0500 In-Reply-To: <1453769169-27479-1-git-send-email-megha.dey@intel.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, 2016-01-25 at 16:46 -0800, Megha Dey wrote: > From: Megha Dey > > The _args_digest is defined as _args+_digest, both of which are the first > members of 2 separate structures, effectively yielding _args_digest to have > a value of zero. Thus, no errors have spawned yet due to this. To ensure > sanity, adding the missing _args_digest offset to the sha1_mb_mgr_submit.S. > Thanks for cleaning this up. Acked-by: Tim Chen > Signed-off-by: Megha Dey > --- > arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S b/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S > index 2ab9560..c420d89 100644 > --- a/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S > +++ b/arch/x86/crypto/sha-mb/sha1_mb_mgr_submit_avx2.S > @@ -197,7 +197,7 @@ len_is_0: > vpinsrd $1, _args_digest+1*32(state , idx, 4), %xmm0, %xmm0 > vpinsrd $2, _args_digest+2*32(state , idx, 4), %xmm0, %xmm0 > vpinsrd $3, _args_digest+3*32(state , idx, 4), %xmm0, %xmm0 > - movl 4*32(state, idx, 4), DWORD_tmp > + movl _args_digest+4*32(state, idx, 4), DWORD_tmp > > vmovdqu %xmm0, _result_digest(job_rax) > movl DWORD_tmp, _result_digest+1*16(job_rax)