From: Lucas De Marchi Subject: Re: Duplicated module names Date: Fri, 29 Jan 2016 17:08:22 -0200 Message-ID: References: <56A91B6A.2060205@oracle.com> <56AA98D6.7020305@oracle.com> <87h9hxrkvs.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Samson Yeung , linux-modules , lkml , linux-crypto@vger.kernel.org, David Airlie , Tomi Valkeinen , Kyungmin Park , Greg Kroah-Hartman , Liam Girdwood , Mark Brown To: Rusty Russell Return-path: Received: from mail-yk0-f177.google.com ([209.85.160.177]:33350 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbcA2TIm (ORCPT ); Fri, 29 Jan 2016 14:08:42 -0500 In-Reply-To: <87h9hxrkvs.fsf@rustcorp.com.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi! On Fri, Jan 29, 2016 at 3:54 AM, Rusty Russell wrote: > Lucas De Marchi writes: >> Hi! >> >> CC'ing Rusty and mailing lists > > Thanks. > >> Rusty and ohers: it looks like both CONFIG_CRC32 and >> CONFIG_CRYPTO_CRC32 can be compiled as module, and they generate >> modules with the same name, crc32. Could that be fixed? > > Gah. Looks like it's been that way since at least 2014, too. > > I think we could rename it to crypto_crc32, but I don't think it's the > only one. Marco, I think depmod should probably FAIL if two modules > have the same name, which would at least find such problems. Yes, I'll do that on kmod, but we need to pay attention to 2 things: - It's possible 2 modules with the same names if they come from different locations (with different priorities) - It doesn't fix the case in which one is a module and the other is builtin. We could still have problem with such a scenario, like was pointed out in this bug report to kmod. Lucas De Marchi