From: Herbert Xu Subject: Re: [PATCH 02/11] crypto: sunxi-ss: prevent compilation on 64-bit Date: Tue, 2 Feb 2016 11:16:16 +0800 Message-ID: <20160202031616.GA16987@gondor.apana.org.au> References: <1454348370-3816-1-git-send-email-andre.przywara@arm.com> <1454348370-3816-3-git-send-email-andre.przywara@arm.com> Reply-To: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Maxime Ripard , Chen-Yu Tsai , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Arnd Bergmann , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "David S . Miller" , linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andre Przywara Return-path: Content-Disposition: inline In-Reply-To: <1454348370-3816-3-git-send-email-andre.przywara-5wv7dgnIgG8@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: linux-crypto.vger.kernel.org On Mon, Feb 01, 2016 at 05:39:21PM +0000, Andre Przywara wrote: > The driver for the sunxi-ss crypto engine is not entirely 64-bit safe, > compilation on arm64 spits some warnings. > The proper fix was deemed to involved [1], so since 64-bit SoCs won't > have this IP block we just disable this driver for 64-bit. > > [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/399988.html > (and the reply) > > Signed-off-by: Andre Przywara I still use COMPILE_TEST to test compile these drivers. So while I don't have a problem with this patch per se, please continue to ensure that it doesn't generate warnings on 64-bit platforms. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt