From: Milan Broz Subject: Re: [PATCH 1/4] crypto: algif_skcipher - Require setkey before accept(2) Date: Sun, 28 Feb 2016 09:18:17 +0100 Message-ID: <56D2AD49.2060907@gmail.com> References: <56D0361B.8040301@gmail.com> <1456487051-14652-1-git-send-email-gmazyland@gmail.com> <56D217E6.4090208@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: stable@vger.kernel.org, Herbert Xu To: Sasha Levin , linux-crypto@vger.kernel.org Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:33997 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756973AbcB1ISV (ORCPT ); Sun, 28 Feb 2016 03:18:21 -0500 In-Reply-To: <56D217E6.4090208@oracle.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 02/27/2016 10:40 PM, Sasha Levin wrote: > On 02/26/2016 06:44 AM, Milan Broz wrote: >> From: Herbert Xu >> >> commit dd504589577d8e8e70f51f997ad487a4cb6c026f upstream. >> >> Some cipher implementations will crash if you try to use them >> without calling setkey first. This patch adds a check so that >> the accept(2) call will fail with -ENOKEY if setkey hasn't been >> done on the socket yet. >> >> Cc: stable@vger.kernel.org >> Reported-by: Dmitry Vyukov >> Signed-off-by: Herbert Xu >> Tested-by: Dmitry Vyukov >> [backported to 4.1 by Milan Broz ] > > Thanks Milan. Can I add your Signed-off-by to this series? yes, Signed-off-by: Milan Broz Thanks, Milan