From: Tadeusz Struk Subject: Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2) Date: Tue, 3 May 2016 13:55:15 -0700 Message-ID: <5711d3da-7d3c-9ba9-d50e-bf0e24cdc1af@intel.com> References: <20160503172536.GC20775@cucamonga.audible.transient.net> <20160430083248.GA20775@cucamonga.audible.transient.net> <26795.1462266613@warthog.procyon.org.uk> <11323.1462307740@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Herbert Xu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: David Howells , Jamie Heilman Return-path: Received: from mga11.intel.com ([192.55.52.93]:39411 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbcECU4C (ORCPT ); Tue, 3 May 2016 16:56:02 -0400 In-Reply-To: <11323.1462307740@warthog.procyon.org.uk> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi Jamie, On 05/03/2016 01:35 PM, David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > >>>> Problem loading in-kernel X.509 certificate (-2) >>> >>> ENOENT? Hmmm... The only place that is generated is in the crypto layer. >>> That suggests missing crypto of some sort. >>> >>> The attached patch enables some debugging in some relevant files if you can >>> try applying it to your kernel. >> >> Alrighty, presumably relevant bits: >> >> X.509: Cert Issuer: Build time autogenerated kernel key >> X.509: Cert Subject: Build time autogenerated kernel key >> X.509: Cert Key Algo: rsa >> X.509: Cert Valid period: 1461826791-4615426791 >> X.509: Cert Signature: rsa + sha512 >> X.509: ==>x509_check_signature() >> X.509: ==>x509_get_sig_params() >> X.509: <==x509_get_sig_params() = 0 >> PKEY: ==>public_key_verify_signature() >> X.509: Cert Verification: -2 > > Hmmm... Okay, the only ways out of public_key_verify_signature() without > printing a leaving message are for snprintf() to overrun (which would return > error -22) or for crypto_alloc_akcipher() to have failed; everything else must > go through the kleave() at the pr_devel() at the bottom of the function. > > Can you stick: > > pr_devel("ALGO: %s\n", alg_name); > > immediately before this line: > > tfm = crypto_alloc_akcipher(alg_name, 0, 0); > > and try it again? > Could you please check if this one fixes the problem for you: https://patchwork.kernel.org/patch/8766361/ Thanks, -- TS