From: Boris Brezillon Subject: Re: [PATCH 1/7] crypto: marvell: Add a macro constant for the size of the crypto queue Date: Wed, 15 Jun 2016 21:20:16 +0200 Message-ID: <20160615212016.32fb8b9d@bbrezillon> References: <1466018134-10779-1-git-send-email-romain.perier@free-electrons.com> <1466018134-10779-2-git-send-email-romain.perier@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Arnaud Ebalard , Gregory Clement , Thomas Petazzoni , "David S. Miller" , Russell King , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Romain Perier Return-path: Received: from down.free-electrons.com ([37.187.137.238]:53087 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932235AbcFOTUT (ORCPT ); Wed, 15 Jun 2016 15:20:19 -0400 In-Reply-To: <1466018134-10779-2-git-send-email-romain.perier@free-electrons.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, 15 Jun 2016 21:15:28 +0200 Romain Perier wrote: > Adding a macro constant to be used for the size of the crypto queue, > instead of using a numeric value directly. It will be easier to > maintain in case we add more than one crypto queue of the same size. > > Signed-off-by: Romain Perier Acked-by: Boris Brezillon > --- > drivers/crypto/marvell/cesa.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/marvell/cesa.c b/drivers/crypto/marvell/cesa.c > index 056a754..fb403e1 100644 > --- a/drivers/crypto/marvell/cesa.c > +++ b/drivers/crypto/marvell/cesa.c > @@ -31,6 +31,9 @@ > > #include "cesa.h" > > +/* Limit of the crypto queue before reaching the backlog */ > +#define CESA_CRYPTO_DEFAULT_MAX_QLEN 50 > + > static int allhwsupport = !IS_ENABLED(CONFIG_CRYPTO_DEV_MV_CESA); > module_param_named(allhwsupport, allhwsupport, int, 0444); > MODULE_PARM_DESC(allhwsupport, "Enable support for all hardware (even it if overlaps with the mv_cesa driver)"); > @@ -416,7 +419,7 @@ static int mv_cesa_probe(struct platform_device *pdev) > return -ENOMEM; > > spin_lock_init(&cesa->lock); > - crypto_init_queue(&cesa->queue, 50); > + crypto_init_queue(&cesa->queue, CESA_CRYPTO_DEFAULT_MAX_QLEN); > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "regs"); > cesa->regs = devm_ioremap_resource(dev, res); > if (IS_ERR(cesa->regs)) -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com