From: "Benedetto, Salvatore" Subject: RE: [PATCH v10 2/3] crypto: kpp - Add DH software implementation Date: Wed, 22 Jun 2016 06:37:50 +0000 Message-ID: <309B30E91F5E2846B79BD9AA9711D03193664C@IRSMSX102.ger.corp.intel.com> References: <1466541931-2875-1-git-send-email-salvatore.benedetto@intel.com> <1466541931-2875-3-git-send-email-salvatore.benedetto@intel.com> <20160622005115.GB27134@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "linux-crypto@vger.kernel.org" , "Benedetto, Salvatore" To: Herbert Xu Return-path: Received: from mga11.intel.com ([192.55.52.93]:21259 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751822AbcFVGlS convert rfc822-to-8bit (ORCPT ); Wed, 22 Jun 2016 02:41:18 -0400 In-Reply-To: <20160622005115.GB27134@gondor.apana.org.au> Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: > -----Original Message----- > From: linux-crypto-owner@vger.kernel.org [mailto:linux-crypto- > owner@vger.kernel.org] On Behalf Of Herbert Xu > Sent: Wednesday, June 22, 2016 1:51 AM > To: Benedetto, Salvatore > Cc: linux-crypto@vger.kernel.org > Subject: Re: [PATCH v10 2/3] crypto: kpp - Add DH software implementation > > On Tue, Jun 21, 2016 at 09:45:30PM +0100, Salvatore Benedetto wrote: > > > > + > > +static int test_dh(struct crypto_kpp *tfm, struct kpp_testvec_dh *vecs, > > + unsigned int tcount) > > +{ > > + int ret, i; > > Please make the kpp test function generic. I'm trying to kill the RSA-specific > test function right now and I don't want to have to do this again. > Can you explain me the benefit in doing so? I thought my patchset had reached an 'acceptable' state by now :-) Thanks, Salvatore > -- > Email: Herbert Xu Home Page: > http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the > body of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html