From: Herbert Xu Subject: Re: [PATCH] crypto: rsa-pkcs1pad - Fix akcipher request allocation Date: Mon, 18 Jul 2016 18:23:14 +0800 Message-ID: <20160718102314.GB13780@gondor.apana.org.au> References: <1468491905-2597-1-git-send-email-salvatore.benedetto@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Salvatore Benedetto , davem@davemloft.net, andrew.zaborowski@intel.com, linux-crypto@vger.kernel.org To: Tadeusz Struk Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:57215 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbcGRKXc (ORCPT ); Mon, 18 Jul 2016 06:23:32 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Jul 14, 2016 at 08:39:18PM -0700, Tadeusz Struk wrote: > Hi Salvatore, > On 07/14/2016 03:25 AM, Salvatore Benedetto wrote: > > Embedding the akcipher_request in pkcs1pad_request don't take > > into account the context space required by the akcipher object. > > I think we do take into account the sub request context. See line 675. > The only thing that is wrong is that the child_req should be at > the end of the structure. This is build tested only. > > ---8<--- > From: Tadeusz Struk > Subject: [PATCH] crypto: rsa-pkcs1pad - fix rsa-pkcs1pad request struct > > To allow for child request context the struct akcipher_request child_req > needs to be at the end of the structure. > > Signed-off-by: Tadeusz Struk Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt