From: Herbert Xu Subject: Re: [PATCH] crypto: DRBG: do not call drbg_instantiate in healt test Date: Tue, 16 Aug 2016 17:49:42 +0800 Message-ID: <20160816094942.GA27104@gondor.apana.org.au> References: <6079382.fWeFLzBGfE@positron.chronox.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: TSarangi@trustwave.com, linux-crypto@vger.kernel.org To: Stephan Mueller Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:60254 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbcHPJuh (ORCPT ); Tue, 16 Aug 2016 05:50:37 -0400 Content-Disposition: inline In-Reply-To: <6079382.fWeFLzBGfE@positron.chronox.de> Sender: linux-crypto-owner@vger.kernel.org List-ID: Stephan Mueller wrote: > Am Dienstag, 9. August 2016, 19:52:46 CEST schrieb Stephan Mueller: > > Hi Tapas, > > I think I found the issue. Can you please test the attached patch? > > ---8<--- > > When calling the DRBG health test in FIPS mode, the Jitter RNG is not > yet present in the kernel crypto API which will cause the instantiation > to fail and thus the health test to fail. > > As the health tests cover the enforcement of various thresholds, invoke > the functions that are supposed to enforce the thresholds directly. > > This patch also saves precious seed. > > Reported-by: Tapas Sarangi > Signed-off-by: Stephan Mueller Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt