From: Herbert Xu Subject: Re: [PATCH] hwrng: core - Allocate memory during module init Date: Wed, 7 Sep 2016 21:16:56 +0800 Message-ID: <20160907131656.GD17176@gondor.apana.org.au> References: <1472977778-23996-1-git-send-email-prasannatsmkumar@gmail.com> <20160907125350.GB17176@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mpm@selenic.com, jslaby@suse.cz, peter@korsgaard.com, Lee Jones , linux-crypto@vger.kernel.org To: PrasannaKumar Muralidharan Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:35763 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757409AbcIGNRT (ORCPT ); Wed, 7 Sep 2016 09:17:19 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Sep 07, 2016 at 06:44:32PM +0530, PrasannaKumar Muralidharan wrote: > > Ah, yes! I can send a revised patch. > Do you think allocating rng_buffer, rng_fillbuf in module init useful? > If not there is no point in sending a new patch with fix. Yes I think it makes sense. Those who want to save a few bytes by keeping the RNGs as modules can always build core HWRNG as a module too. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt