From: Nicolas Ferre Subject: Re: [PATCH -next] hwrng: atmel - use clk_disable_unprepare instead of clk_disable Date: Mon, 14 Nov 2016 09:02:28 +0100 Message-ID: References: <1478876207-29820-1-git-send-email-weiyj.lk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Cc: Wei Yongjun , To: Wei Yongjun , Matt Mackall , Herbert Xu , Wenyou Yang Return-path: Received: from eusmtp01.atmel.com ([212.144.249.242]:29131 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbcKNIDL (ORCPT ); Mon, 14 Nov 2016 03:03:11 -0500 In-Reply-To: <1478876207-29820-1-git-send-email-weiyj.lk@gmail.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Le 11/11/2016 ? 15:56, Wei Yongjun a ?crit : > From: Wei Yongjun > > Since clk_prepare_enable() is used to get trng->clk, we should > use clk_disable_unprepare() to release it for the error path. > > Signed-off-by: Wei Yongjun Acked-by: Nicolas Ferre Thank you. Best regards, > --- > drivers/char/hw_random/atmel-rng.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c > index ae7cae5..661c82c 100644 > --- a/drivers/char/hw_random/atmel-rng.c > +++ b/drivers/char/hw_random/atmel-rng.c > @@ -94,7 +94,7 @@ static int atmel_trng_probe(struct platform_device *pdev) > return 0; > > err_register: > - clk_disable(trng->clk); > + clk_disable_unprepare(trng->clk); > return ret; > } > > -- Nicolas Ferre