From: Sam Ravnborg Subject: Re: [PATCH v5 1/1] crypto: add virtio-crypto driver Date: Wed, 7 Dec 2016 21:20:39 +0100 Message-ID: <20161207202039.GA27878@ravnborg.org> References: <1480595945-63656-2-git-send-email-arei.gonglei@huawei.com> <201612041032.loAEWLIy%fengguang.wu@intel.com> <33183CC9F5247A488A2544077AF19020DA1528DE@DGGEMA505-MBX.china.huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "Xuquan \(Quan Xu\)" , "Huangweidong \(C\)" , "mst@redhat.com" , "qemu-devel@nongnu.org" , "Wanzongshun \(Vincent\)" , "virtualization@lists.linux-foundation.org" , "Zhoujian \(jay, Euler\)" , "arei.gonglei@hotmail.com" , "virtio-dev@lists.oasis-open.org" , kbuild test robot , "Hanweidong \(Randy\)" , longpeng , "linux-crypto@vger.kernel.org" , Luonengjun , "stefanha@redhat.com" , "herbert@gondor.apana.org.au" , Claudio Fontana , "linux-kernel@vge To: "Gonglei (Arei)" Return-path: Content-Disposition: inline In-Reply-To: <33183CC9F5247A488A2544077AF19020DA1528DE@DGGEMA505-MBX.china.huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: linux-crypto.vger.kernel.org On Mon, Dec 05, 2016 at 03:12:52AM +0000, Gonglei (Arei) wrote: > I don't think the root cause of those warnings are introduced by virtio-crypto driver. > > What's your opinion? Sam and David? Root cause here is that arch/sparc/include/asm/topology_64.h references cpu_data without including arch/sparc/include/asm/cpudata.h I think other architectures pull in the dependency from either smp.h or they have it topology.h. The easy fix would be to include cpudata.h in arch/sparc/include/asm/topology_64.h. And that should also be a correct fix. Could you include this in your patch-set and build test it? Sam