From: Bart Van Assche Subject: Re: [PATCH] linux/types.h: enable endian checks for all sparse builds Date: Thu, 8 Dec 2016 05:21:47 +0000 Message-ID: References: <1481164052-28036-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Jason Wang , "linux-kbuild@vger.kernel.org" , Michal Marek , Arnd Bergmann , Greg Kroah-Hartman , "Matt Mackall" , Herbert Xu , "David Airlie" , Gerd Hoffmann , Ohad Ben-Cohen , Christian Borntraeger , "Cornelia Huck" , "James E.J. Bottomley" , "David S. Miller" , "Jens Axboe" , Neil Armstrong , "Stefan Hajnoczi" , Asias He , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linus Torvalds , Christoph Hellwig Return-path: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On 12/07/16 18:29, Michael S. Tsirkin wrote:=0A= > By now, linux is mostly endian-clean. Enabling endian-ness=0A= > checks for everyone produces about 200 new sparse warnings for me -=0A= > less than 10% over the 2000 sparse warnings already there.=0A= >=0A= > Not a big deal, OTOH enabling this helps people notice=0A= > they are introducing new bugs.=0A= >=0A= > So let's just drop __CHECK_ENDIAN__. Follow-up patches=0A= > can drop distinction between __bitwise and __bitwise__.=0A= =0A= Hello Michael,=0A= =0A= This patch makes a whole bunch of ccflags-y +=3D -D__CHECK_ENDIAN__ =0A= statements obsolete. Have you considered to remove these statements?=0A= =0A= Additionally, there are notable exceptions to the rule that most drivers = =0A= are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it = =0A= would remain possible to check such drivers with sparse without enabling = =0A= endianness checks. Have you considered to change #ifdef __CHECK_ENDIAN__ = =0A= into e.g. #ifndef __DONT_CHECK_ENDIAN__?=0A= =0A= Thanks,=0A= =0A= Bart.=0A=