From: "Gonglei (Arei)" Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver Date: Thu, 15 Dec 2016 01:08:51 +0000 Message-ID: <33183CC9F5247A488A2544077AF19020DA16320F@DGGEMA505-MBX.china.huawei.com> References: <1481716249-185392-1-git-send-email-arei.gonglei@huawei.com> <1481716249-185392-2-git-send-email-arei.gonglei@huawei.com> <33183CC9F5247A488A2544077AF19020DA163033@DGGEMA505-MBX.china.huawei.com> <82063967A54EF84C8AFCD6BD7F6AD93310C14374@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: "Huangweidong (C)" , Claudio Fontana , "mst@redhat.com" , Luonengjun , "Hanweidong (Randy)" , "Xuquan (Quan Xu)" , "Wanzongshun (Vincent)" , "stefanha@redhat.com" , "Zhoujian (jay, Euler)" , "cornelia.huck@de.ibm.com" , longpeng , "arei.gonglei@hotmail.com" , "davem@davemloft.net" , "Wubin (H)" , "herbert@gondor.apana.org.au" To: "Zeng, Xin" , Halil Pasic , "linux-kernel@vger.kernel.org" , "qemu-devel@nongnu.org" , "virtio-dev@lists.oasis-open.org" , "virtualization@lists.linux-foundation.org" , "linux-crypto@vger.kernel.org" Return-path: Received: from szxga01-in.huawei.com ([45.249.212.187]:2321 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752944AbcLOBJT (ORCPT ); Wed, 14 Dec 2016 20:09:19 -0500 In-Reply-To: <82063967A54EF84C8AFCD6BD7F6AD93310C14374@SHSMSX103.ccr.corp.intel.com> Content-Language: zh-CN Sender: linux-crypto-owner@vger.kernel.org List-ID: Regards, -Gonglei > -----Original Message----- > From: Zeng, Xin [mailto:xin.zeng@intel.com] > Sent: Thursday, December 15, 2016 8:59 AM > To: Gonglei (Arei); Halil Pasic; linux-kernel@vger.kernel.org; > qemu-devel@nongnu.org; virtio-dev@lists.oasis-open.org; > virtualization@lists.linux-foundation.org; linux-crypto@vger.kernel.org > Cc: Huangweidong (C); Claudio Fontana; mst@redhat.com; Luonengjun; > Hanweidong (Randy); Xuquan (Quan Xu); Wanzongshun (Vincent); > stefanha@redhat.com; Zhoujian (jay, Euler); cornelia.huck@de.ibm.com; > longpeng; arei.gonglei@hotmail.com; davem@davemloft.net; Wubin (H); > herbert@gondor.apana.org.au > Subject: RE: [Qemu-devel] [PATCH v7 1/1] crypto: add virtio-crypto driver > > On Thursday, December 15, 2016 8:45 AM, Gonglei (Arei) Wrote: > < > > diff --git a/drivers/crypto/virtio/virtio_crypto_core.c > < > b/drivers/crypto/virtio/virtio_crypto_core.c > < > > new file mode 100644 > < > > index 0000000..c0854a1 > < > > --- /dev/null > < > > +++ b/drivers/crypto/virtio/virtio_crypto_core.c > < > > @@ -0,0 +1,474 @@ > < > [..] > < > > + > < > > +static void virtcrypto_dataq_callback(struct virtqueue *vq) > < > > +{ > < > > + struct virtio_crypto *vcrypto = vq->vdev->priv; > < > > + struct virtio_crypto_request *vc_req; > < > > + unsigned long flags; > < > > + unsigned int len; > < > > + struct ablkcipher_request *ablk_req; > < > > + int error; > < > > + > < > > + spin_lock_irqsave(&vcrypto->lock, flags); > < > > < > Would it make sense to use a per virtqueue lock > < > like in virtio_blk for example instead of locking on the whole > < > device? OK, it seems you use only one dataqueue, so it > < > may not be that relevant. > < > > < Currently yes, both the backend device (cryptodev-backend-builtin) > < and the frontend driver use one dataqueue. > < > > I think it makes sense to use per virtqueue lock here though it only uses one > queue so far, > but in the spec we already have multi queues support. > Yes, I agree. Will do that in V8 soon. Hope to catch up with Michael's pull request for 4.10. Regards, -Gonglei