From: Daniel Borkmann Subject: Re: [PATCH v2 7/8] net: Rename TCA*BPF_DIGEST to ..._SHA256 Date: Wed, 11 Jan 2017 01:50:49 +0100 Message-ID: <58758169.2020408@iogearbox.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "Jason A. Donenfeld" , Hannes Frederic Sowa , Alexei Starovoitov , Eric Dumazet , Eric Biggers , Tom Herbert , "David S. Miller" , Alexei Starovoitov To: Andy Lutomirski , Netdev , LKML , Linux Crypto Mailing List Return-path: Received: from www62.your-server.de ([213.133.104.62]:52515 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758566AbdAKAu4 (ORCPT ); Tue, 10 Jan 2017 19:50:56 -0500 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On 01/11/2017 12:24 AM, Andy Lutomirski wrote: > This makes it easier to add another digest algorithm down the road if > needed. It also serves to force any programs that might have been > written against a kernel that had the old field name to notice the > change and make any necessary changes. > > This shouldn't violate any stable API policies, as no released kernel > has ever had TCA*BPF_DIGEST. Imho, this and patch 6/8 is not really needed. Should there ever another digest alg be used (doubt it), then you'd need a new nl attribute and fdinfo line anyway to keep existing stuff intact. Nobody made the claim that you can just change this underneath and not respecting abi for existing applications when I read from above that such apps now will get "forced" to notice a change.