From: Herbert Xu Subject: Re: x86-64: Maintain 16-byte stack alignment Date: Thu, 12 Jan 2017 23:06:50 +0800 Message-ID: <20170112150650.GA16000@gondor.apana.org.au> References: <20170110143340.GA3787@gondor.apana.org.au> <20170110143913.GA3822@gondor.apana.org.au> <20170112070534.GA14016@gondor.apana.org.au> <20170112150318.eq4lmfitxvitpix4@treble> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andy Lutomirski , Linus Torvalds , Linux Kernel Mailing List , Linux Crypto Mailing List , Ingo Molnar , Thomas Gleixner , Andy Lutomirski , Ard Biesheuvel To: Josh Poimboeuf Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:45403 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750960AbdALPHG (ORCPT ); Thu, 12 Jan 2017 10:07:06 -0500 Content-Disposition: inline In-Reply-To: <20170112150318.eq4lmfitxvitpix4@treble> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Jan 12, 2017 at 09:03:18AM -0600, Josh Poimboeuf wrote: > > For the entry code, could we just replace all calls with CALL_ALIGNED? > That might be less intrusive than trying to adjust all the pt_regs > accesses. > > Then to ensure that nobody ever uses 'call' directly: > > '#define call please-use-CALL-ALIGNED-instead-of-call' > > I think that would be possible if CALL_ALIGNED were a ".macro". The trouble with that is that you have got things like TRACE_IRQS_OFF which are also used outside of the entry code. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt