From: Herbert Xu Subject: Re: crypto: hang in crypto_larval_lookup Date: Thu, 23 Feb 2017 19:19:57 +0800 Message-ID: <20170223111957.GA14000@gondor.apana.org.au> References: <02b80c39-0fd5-b7bd-39da-07e5d71abbad@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, schwidefsky@de.ibm.com To: Harald Freudenberger Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:45219 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751099AbdBWL5z (ORCPT ); Thu, 23 Feb 2017 06:57:55 -0500 Content-Disposition: inline In-Reply-To: <02b80c39-0fd5-b7bd-39da-07e5d71abbad@linux.vnet.ibm.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Harald Freudenberger wrote: > > Hello all > > I am currently following a hang at modprobe aes_s390 where > crypto_register_alg() does not come back for the xts(aes) algorithm. > > The registration is waiting forever in algapi.c crypto_wait_for_test() but > the completion never occurs. The cryptomgr is triggering a test via > kthread_run to invoce cryptomgr_probe and this thread is calling the > create() function of the xts template (file xts.c). Following this thread > it comes down to api.c crypto_larval_lookup(name="aes") which is first > requesting the module "crypto-aes" via request_module() successful and then > blocking forever in requesting the module "crypto-aes-all". > > The xts(aes) has at registration CRYPTO_ALG_NEED_FALLBACK flag on. > > This problem is seen since about 6 weeks now, first only on the linux next > kernel. Now it appers on the 4.10-rc kernels as well. And I still have no > idea on how this could be fixed or what's wrong with just the xts > registration (ecb, cbc, ctr work fine). > > Any ideas or hints? Sorry, my fault. I should've converted all the fallback users of the old blkcipher interface over to skcipher before converting the core algorithms to skcipher. I'll send a patch. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt