From: PrasannaKumar Muralidharan Subject: Re: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver Date: Mon, 27 Mar 2017 09:53:11 +0530 Message-ID: References: <20170325162654.3827-1-krzk@kernel.org> <2736911.EcZSki4vB1@positron.chronox.de> <20170326180012.3eic4bt2p6h6u3nh@kozik-lap> <4479175.Jfq03yCxQW@tauon.atsec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-samsung-soc@vger.kernel.org, Herbert Xu , Arnd Bergmann , Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Javier Martinez Canillas , Kukjin Kim , linux-crypto@vger.kernel.org, Matt Mackall , Olof Johansson , "David S. Miller" , linux-arm-kernel@lists.infradead.org To: =?UTF-8?Q?Stephan_M=C3=BCller?= Return-path: In-Reply-To: <4479175.Jfq03yCxQW@tauon.atsec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org List-Id: linux-crypto.vger.kernel.org > Oh my, if you are right with your first guess, this is a bad DRNG design. > > Just out of curiousity: what happens if a caller invokes the seed function > twice or more times (each time with the sufficient amount of bits)? What is > your guess here? Should the second seed use the random data generated by the device? Regards, PrasannaKumar