From: SF Markus Elfring Subject: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() Date: Wed, 19 Apr 2017 11:10:07 +0200 Message-ID: <38c41219-7e7f-3a3e-29dd-04ae2d57beaa@users.sourceforge.net> References: <4d9fbb01-e12f-eb5c-7ecd-5a2a10fd5110@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: LKML , kernel-janitors@vger.kernel.org To: linux-crypto@vger.kernel.org, "David S. Miller" , Herbert Xu , Matt Mackall , Shannon Nelson Return-path: Received: from mout.web.de ([212.227.15.14]:52813 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933045AbdDSJK2 (ORCPT ); Wed, 19 Apr 2017 05:10:28 -0400 In-Reply-To: <4d9fbb01-e12f-eb5c-7ecd-5a2a10fd5110@users.sourceforge.net> Content-Language: en-GB Sender: linux-crypto-owner@vger.kernel.org List-ID: From: Markus Elfring Date: Wed, 19 Apr 2017 10:30:47 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/char/hw_random/n2-drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c index 31cbdbbaebfc..92dd4e925315 100644 --- a/drivers/char/hw_random/n2-drv.c +++ b/drivers/char/hw_random/n2-drv.c @@ -748,9 +748,7 @@ static int n2rng_probe(struct platform_device *op) dev_info(&op->dev, "Registered RNG HVAPI major %lu minor %lu\n", np->hvapi_major, np->hvapi_minor); - - np->units = devm_kzalloc(&op->dev, - sizeof(struct n2rng_unit) * np->num_units, + np->units = devm_kcalloc(&op->dev, np->num_units, sizeof(*np->units), GFP_KERNEL); err = -ENOMEM; if (!np->units) -- 2.12.2