From: Herbert Xu Subject: Re: [PATCH 1/9] crypto: add hmac IPAD/OPAD constant Date: Thu, 18 May 2017 12:10:45 +0800 Message-ID: <20170518041045.GA32127@gondor.apana.org.au> References: <20170424141629.27155-1-clabbe.montjoie@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, thomas.lendacky@amd.com, gary.hook@amd.com, boris.brezillon@free-electrons.com, arno@natisbad.org, matthias.bgg@gmail.com, giovanni.cabiddu@intel.com, salvatore.benedetto@intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, qat-linux@intel.com To: Corentin Labbe Return-path: Received: from [128.1.224.119] ([128.1.224.119]:41768 "EHLO deadmen.hmeau.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753164AbdERELY (ORCPT ); Thu, 18 May 2017 00:11:24 -0400 Content-Disposition: inline In-Reply-To: <20170424141629.27155-1-clabbe.montjoie@gmail.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Apr 24, 2017 at 04:16:21PM +0200, Corentin Labbe wrote: > Many HMAC users directly use directly 0x36/0x5c values. > It's better with crypto to use a name instead of directly some crypto > constant. > > This patch simply add HMAC_IPAD_VALUE/HMAC_OPAD_VALUE defines. > > Signed-off-by: Corentin Labbe > --- > crypto/hmac.c | 4 ++-- > include/crypto/hash.h | 3 +++ > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/crypto/hmac.c b/crypto/hmac.c > index 72e38c0..4a997ce 100644 > --- a/crypto/hmac.c > +++ b/crypto/hmac.c > @@ -74,8 +74,8 @@ static int hmac_setkey(struct crypto_shash *parent, > memcpy(opad, ipad, bs); > > for (i = 0; i < bs; i++) { > - ipad[i] ^= 0x36; > - opad[i] ^= 0x5c; > + ipad[i] ^= HMAC_IPAD_VALUE; > + opad[i] ^= HMAC_OPAD_VALUE; > } > > return crypto_shash_init(shash) ?: > diff --git a/include/crypto/hash.h b/include/crypto/hash.h > index b5727bc..0f51ff1 100644 > --- a/include/crypto/hash.h > +++ b/include/crypto/hash.h > @@ -922,4 +922,7 @@ static inline void shash_desc_zero(struct shash_desc *desc) > sizeof(*desc) + crypto_shash_descsize(desc->tfm)); > } > > +#define HMAC_IPAD_VALUE 0x36 > +#define HMAC_OPAD_VALUE 0x5c > + > #endif /* _CRYPTO_HASH_H */ I think this should go into a header file specific to hmac. Since I don't see an existing hmac header file you should create one for it. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt