From: Thomas Petazzoni Subject: Re: [PATCH v5 1/4] Documentation/bindings: Document the SafeXel cryptographic engine driver Date: Mon, 22 May 2017 21:34:16 +0200 Message-ID: <20170522213416.7440ee32@free-electrons.com> References: <20170522144514.6654-1-antoine.tenart@free-electrons.com> <20170522144514.6654-2-antoine.tenart@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Cc: herbert@gondor.apana.org.au, davem@davemloft.net, jason@lakedaemon.net, andrew@lunn.ch, gregory.clement@free-electrons.com, sebastian.hesselbarth@gmail.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, oferh@marvell.com, igall@marvell.com, nadavh@marvell.com, robin.murphy@arm.com To: Antoine Tenart Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:52107 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757285AbdEVTeS (ORCPT ); Mon, 22 May 2017 15:34:18 -0400 In-Reply-To: <20170522144514.6654-2-antoine.tenart@free-electrons.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hello, On Mon, 22 May 2017 16:45:11 +0200, Antoine Tenart wrote: > + interrupts = , You already got the feedback previously that an interrupt that is both edge and level at the same time doesn't make sense. Could you fix this? Also, the DTs that have already been merged by Grégory are wrong for the same reason and should be fixed. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com