From: Theodore Ts'o Subject: Re: [PATCH v4 10/13] net/neighbor: use get_random_u32 for 32-bit hash random Date: Wed, 7 Jun 2017 23:00:33 -0400 Message-ID: <20170608030033.ln7f2d6busshtxx7@thunk.org> References: <20170606174804.31124-1-Jason@zx2c4.com> <20170606174804.31124-11-Jason@zx2c4.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , David Miller , Eric Biggers To: "Jason A. Donenfeld" Return-path: Received: from imap.thunk.org ([74.207.234.97]:58128 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdFHDAh (ORCPT ); Wed, 7 Jun 2017 23:00:37 -0400 Content-Disposition: inline In-Reply-To: <20170606174804.31124-11-Jason@zx2c4.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Jun 06, 2017 at 07:48:01PM +0200, Jason A. Donenfeld wrote: > Using get_random_u32 here is faster, more fitting of the use case, and > just as cryptographically secure. It also has the benefit of providing > better randomness at early boot, which is when many of these structures > are assigned. > > Signed-off-by: Jason A. Donenfeld > Cc: David Miller Applied to the random.git dev branch, thanks. - Ted