From: Theodore Ts'o Subject: Re: [PATCH v4 11/13] net/route: use get_random_int for random counter Date: Wed, 7 Jun 2017 23:01:54 -0400 Message-ID: <20170608030154.mwniddfm6hke773t@thunk.org> References: <20170606174804.31124-1-Jason@zx2c4.com> <20170606174804.31124-12-Jason@zx2c4.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Crypto Mailing List , LKML , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , David Miller , Eric Biggers To: "Jason A. Donenfeld" Return-path: Received: from imap.thunk.org ([74.207.234.97]:58152 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751203AbdFHDB5 (ORCPT ); Wed, 7 Jun 2017 23:01:57 -0400 Content-Disposition: inline In-Reply-To: <20170606174804.31124-12-Jason@zx2c4.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Jun 06, 2017 at 07:48:02PM +0200, Jason A. Donenfeld wrote: > Using get_random_int here is faster, more fitting of the use case, and > just as cryptographically secure. It also has the benefit of providing > better randomness at early boot, which is when many of these structures > are assigned. > > Also, semantically, it's not really proper to have been assigning an > atomic_t in this way before, even if in practice it works fine. > > Signed-off-by: Jason A. Donenfeld > Cc: David Miller Applied to the dev branch of the random.git branch, thanks. - Ted