From: Herbert Xu Subject: Re: [PATCH] hwrng: do not warn when there are no devices Date: Mon, 19 Jun 2017 14:21:15 +0800 Message-ID: <20170619062115.GA13498@gondor.apana.org.au> References: <20170512041734.31945-1-vapier@gentoo.org> <20170619041234.GA12984@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: PrasannaKumar Muralidharan , Matt Mackall , linux-crypto@vger.kernel.org To: Mike Frysinger Return-path: Received: from orcrist.hmeau.com ([104.223.48.154]:59604 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbdFSGVj (ORCPT ); Mon, 19 Jun 2017 02:21:39 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: > > in order to make tpm-rng react in the way you're implying, the TPM > subsystem would need to add a notification chain for transitions from > none<->some devices, then tpm-rng could subscribe to that, and during > those transition points, it would call hwrng_register/hwrng_unregister > to make itself visible accordingly to the hwrng subsystem. maybe > someone on the TPM side would be interested in writing all that logic, > but it sounds excessive for this minor usage. the current tpm-rng > driver is *extremely* simple -- it's 3 funcs, each of which are 1 > line. It's simple and it's broken, as far as the way it hooks into the hwrng is concerned. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt