From: Herbert Xu Subject: Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request Date: Fri, 23 Jun 2017 14:48:37 +0800 Message-ID: <20170623064837.GA29139@gondor.apana.org.au> References: <20170606134417.18850-1-clabbe.montjoie@gmail.com> <20170606134417.18850-3-clabbe.montjoie@gmail.com> <20170619052707.GA13180@gondor.apana.org.au> <20170619075524.GA27419@Red> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: Corentin Labbe Return-path: Received: from orcrist.hmeau.com ([104.223.48.154]:35922 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754277AbdFWGs6 (ORCPT ); Fri, 23 Jun 2017 02:48:58 -0400 Content-Disposition: inline In-Reply-To: <20170619075524.GA27419@Red> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote: > > Since there are two different user of "crypto engine + ablkcipher", it will be not easy to convert them in one serie. (I could do it, but I simply could not test it for OMAP (lack of hw)) > And any new user which want to use crypto engine+skcipher (like me with the sun8i-ce driver) are simply stuck. You're right. We'll need to do this in a backwards-compatible way. In fact we already do something similar in skcipher.c itself. Simply look at the cra_type field and if it matches blkcipher/ablkcipher/givcipher then it's legacy ablkcipher, otherwise it's skcipher. Also the way crypto_engine looks at the request type in the data-path is suboptimal. This should really be built into the cra_type object. For example, we can have cra_type->engine->prepare_request which would just do the right thing. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt