From: =?iso-8859-2?Q?Horia_Geant=E3?= Subject: Re: [PATCH] crypto: caam - properly set IV after {en,de}crypt Date: Wed, 28 Jun 2017 13:42:50 +0000 Message-ID: References: <20170602122446.2427-1-david@sigma-star.at> <20170628132710.97278-1-david@sigma-star.at> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Cc: "richard@sigma-star.at" , "linux-crypto@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" To: David Gstir , Dan Douglass , "herbert@gondor.apana.org.au" , "davem@davemloft.net" Return-path: Received: from mail-ve1eur01on0066.outbound.protection.outlook.com ([104.47.1.66]:7232 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751469AbdF1Nmz (ORCPT ); Wed, 28 Jun 2017 09:42:55 -0400 Content-Language: en-US Sender: linux-crypto-owner@vger.kernel.org List-ID: On 6/28/2017 4:27 PM, David Gstir wrote:=0A= > Certain cipher modes like CTS expect the IV (req->info) of=0A= > ablkcipher_request (or equivalently req->iv of skcipher_request) to=0A= > contain the last ciphertext block when the {en,de}crypt operation is done= .=0A= > This is currently not the case for the CAAM driver which in turn breaks= =0A= > e.g. cts(cbc(aes)) when the CAAM driver is enabled.=0A= > =0A= > This patch fixes the CAAM driver to properly set the IV after the=0A= > {en,de}crypt operation of ablkcipher finishes.=0A= > =0A= > This issue was revealed by the changes in the SW CTS mode in commit=0A= > 0605c41cc53ca ("crypto: cts - Convert to skcipher")=0A= > =0A= > Cc: # 4.8+=0A= > Signed-off-by: David Gstir =0A= Reviewed-by: Horia Geant=E3 =0A= =0A= Thanks,=0A= Horia=0A= =0A=