From: Logan Gunthorpe Subject: Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs Date: Thu, 20 Jul 2017 09:39:33 -0600 Message-ID: References: <20170718165528.7383-1-logang@deltatee.com> <20170718165528.7383-2-logang@deltatee.com> <87iniphsug.fsf@concordia.ellerman.id.au> <15b6ea7d-5817-c0cd-aee4-c8a52d8808f9@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 8bit Cc: Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates , Benjamin Herrenschmidt , Paul Mackerras , Nicholas Piggin , Suresh Warrier , Oliver O'Halloran To: =?UTF-8?Q?Horia_Geant=c4=83?= , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-ntb@googlegroups.com" , "linux-crypto@vger.kernel.org" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On 20/07/17 06:36 AM, Horia Geant? wrote: > include/asm-generic/iomap.h is included before > include/linux/io-64-nonatomic-lo-hi.h: > > include/linux/io.h -> arch/powerpc/include/asm/io.h -> > include/asm-generic/iomap.h > > Thus, the "extern" version of ioread64_lo_hi and friends will be used > (and not the inline version from io-64-nonatomic-lo-hi.h). > > But for this kernel .config: > -CONFIG_GENERIC_IOMAP=n and > -there is no implementation of io{read|write}64[be]{_lo_hi|_hi_lo} in > arch/powerpc/kernel/iomap.c Ah, thanks for the triage. I'll take a look at fixing this for a v5. Logan