From: Boris Brezillon Subject: Re: [PATCH] crypto: marvell - Switch cipher algs to the skcipher interface Date: Fri, 13 Oct 2017 15:39:25 +0200 Message-ID: <20171013153925.30ff5095@bbrezillon> References: <20171013133032.6025-1-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Antoine Tenart To: Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Return-path: Received: from mail.free-electrons.com ([62.4.15.54]:52857 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758060AbdJMNj1 (ORCPT ); Fri, 13 Oct 2017 09:39:27 -0400 In-Reply-To: <20171013133032.6025-1-boris.brezillon@free-electrons.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, 13 Oct 2017 15:30:32 +0200 Boris Brezillon wrote: > crypto_alg is not supposed to be directly implemented by crypto engine > driver. Drivers should instead implement specialized interfaces like *drivers. > ahash_alg or skcipher_alg. > > Migrate to all cipher algorithms to the skcipher_alg interface. While at s/Migrate to all/Migrate all/ > it, get rid of all references to ablkcipher including in internal struct > or function names. > > Signed-off-by: Boris Brezillon