From: Kim Phillips Subject: Re: [PATCH RESEND 1/4] crypto: caam: add caam-dma node to SEC4.0 device tree binding Date: Mon, 13 Nov 2017 09:21:32 -0600 Message-ID: <20171113092132.55f13384cede1f283a53434b@arm.com> References: <20171030134654.13729-1-horia.geanta@nxp.com> <20171030134654.13729-2-horia.geanta@nxp.com> <20171030092424.1279add003c96ced4233bd2d@arm.com> <20171109103437.834f8ddb5c62e5253002b2d0@arm.com> <20171110104430.28b2f56f910b7514d778c4b2@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Radu Andrei Alexe , Vinod Koul , Herbert Xu , "David S. Miller" , "Dan Douglass" , Shawn Guo , "dmaengine@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" To: Horia =?UTF-8?B?R2VhbnTEgw==?= Return-path: Received: from foss.arm.com ([217.140.101.70]:47774 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752735AbdKMPVg (ORCPT ); Mon, 13 Nov 2017 10:21:36 -0500 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, 13 Nov 2017 08:32:24 +0000 Horia Geantă wrote: > On 11/10/2017 6:44 PM, Kim Phillips wrote: > > On Fri, 10 Nov 2017 08:02:01 +0000 > > Radu Andrei Alexe wrote: > [snip]>> 2. I wanted this driver to be tracked by the dma engine team. > They have > >> the right expertise to provide adequate feedback. If all the code was in > >> the crypto directory they wouldn't know about this driver or any > >> subsequent changes to it. > > > > dma subsystem bits could still be put in the dma area if deemed > > necessary but I don't think it is: I see > > drivers/crypto/ccp/ccp-dmaengine.c calls dma_async_device_register for > > example. > > > Please see previous discussion with Vinod: > https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg21468.html Vinod says: "If the dma controller is internal to crypto, then it might be okay to be inside the crypto driver." Is that the case for the CCP driver? Isn't it the case here? In any case, I don't care that much about that, this all begat from new *devices* coming out of nowhere. > > What is the rationale for using the crypto h/w as a dma engine anyway? > SoCs that don't have a system DMA, for e.g. LS1012A. OK. Kim